Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check apps properties #619

Merged
merged 19 commits into from
Aug 22, 2024
Merged

add check apps properties #619

merged 19 commits into from
Aug 22, 2024

Conversation

mingxueg-nv
Copy link
Contributor

@mingxueg-nv mingxueg-nv commented Aug 15, 2024 •
edited
Loading

Fixes # .

Description

Add check different apps properties in monai ci verify_bundle().

Status

Work in progress

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

yiheng-wang-nv
yiheng-wang-nv reviewed Aug 16, 2024
View reviewed changes
ci/verify_bundle.py Outdated Show resolved Hide resolved
@YanxuanLiu
Copy link
Collaborator

/build

3 similar comments
@YanxuanLiu
Copy link
Collaborator

/build

@YanxuanLiu
Copy link
Collaborator

/build

@YanxuanLiu
Copy link
Collaborator

/build

@YanxuanLiu
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

/build

1 similar comment
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

/build

yiheng-wang-nv
yiheng-wang-nv approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready, and after revert the vista3d tmp change, we can merge it.

@yiheng-wang-nv
Copy link
Collaborator

/build

1 similar comment
@YanxuanLiu
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv enabled auto-merge (squash) August 21, 2024 10:20
@yiheng-wang-nv
Copy link
Collaborator

/build

1 similar comment
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv merged commit 4dac76f into dev Aug 22, 2024
4 checks passed
@yiheng-wang-nv yiheng-wang-nv deleted the properties_dev branch August 22, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingxueg-nv @YanxuanLiu @yiheng-wang-nv